fix: fix max_retries is hardcode#33619
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue by enhancing configuration flexibility for Redis connection pooling and making HTTP request retry behavior configurable. The changes ensure that environment variables for Redis maximum connections are parsed correctly, and HTTP requests can leverage a dynamic retry mechanism, improving the robustness of the system. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pyrefly DiffNo changes detected. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request makes two improvements. It allows REDIS_MAX_CONNECTIONS to be set as an empty environment variable, correctly interpreting it as unset. It also configures the HTTP request node to use a default number of retries instead of a hardcoded zero. My feedback points out a small redundancy in how the retry value is passed, suggesting a simplification.
There was a problem hiding this comment.
Pull request overview
This PR adjusts runtime configuration behavior in the API layer by (1) changing how the HTTP Request workflow node configures HTTP-layer retries and (2) improving Redis settings parsing to treat an empty env var as “unset”.
Changes:
- Update the HTTP Request node to pass a configurable default retry count into its HTTP executor.
- Add a Pydantic
field_validatorto allowREDIS_MAX_CONNECTIONS=""in env/.env to be interpreted asNone.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| api/dify_graph/nodes/http_request/node.py | Changes the Executor construction to use a config-derived max_retries instead of hard-coding 0. |
| api/configs/middleware/cache/redis_config.py | Adds env parsing behavior so empty-string REDIS_MAX_CONNECTIONS becomes None (unset). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pyrefly DiffNo changes detected. |
dosubot
bot
added
the
size:S
Important
Fixes #<issue number>.Summary
fix #33571
fix #33592
Screenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods